Feature/us charger #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed debug comment, modified version name
kokosabu
reviewed
Apr 22, 2024
main.cpp
Outdated
| @@ -399,6 +399,15 @@ class auto_charger { // Variables Half-Implemented (Not Thermistors ADC) | |||
| set_enable(false); | |||
| send_heartbeat(); | |||
| } | |||
| bool is_charger_ready() const { | |||
| if(connector_v > (CHARGING_VOLTAGE * 0.9)){ | |||
There was a problem hiding this comment.
"以上"だとしたら符号が違う。
( 大差ないとは思います。 )
If it is "more than", the sign is different.
( I don't think there is much difference. )
There was a problem hiding this comment.
ありがとうございます。ここのしきい値はあまり厳密な値ではなく、Charger側のSSRがONしたかどうかが見れればよいので、> で問題ありません。
Thank you very much. The threshold value here is not very strict, but just enough to see if the SSR on the Charger side is turned on or not, so > is fine.
There was a problem hiding this comment.
なるほど。承知しました。
I see. I understand.
kokosabu
approved these changes
Apr 23, 2024
shujima
approved these changes
Apr 24, 2024
| @@ -882,8 +899,10 @@ class state_controller { // Variables Implemented | |||
| LOG("plugged to manual charger\n"); | |||
| set_new_state(POWER_STATE::MANUAL_CHARGE); | |||
| } else if (!charge_guard_asserted && ac.is_docked() && bmu.is_chargable()) { | |||
There was a problem hiding this comment.
ac.is_docked()とis_charger_ready()の2つで電圧を評価しているのがやや気持ち悪い感じがします。is_docked()が本来は充電中ではない充電器が出している5Vを検出するための関数であるのに、目的外の利用になっているような感じです。
ただ弊害はなく、is_dockedを消しちゃうと温度センサの評価が無くなったりもするので、このまま修正しなくていいのかなと思いました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastChargeではベースとしている充電器の違いから、従来シーケンスのAMR側SSRオン→Charger側SSRオンとすると、AMR側SSRがオンした瞬間にCharget側SSRのダイオードを経由してAMR側から電流が流れてしまい、BMUが過電流を検出してAMRが落ちてしまう。その対策として、Charger側SSRをONした後に、AMR側SSRをONする。これによりCharger側の電位が高い状態でAMR側SSRがオンするので、AMR側から電流が流れることを防止できる。
対策として
としている。この対策は、FastChargeでも従来の充電器でもどちらにAMRが充電しにいっても問題なく動作する。
Due to the difference in the chargers on which FastCharge is based, if the conventional sequence is AMR side SSR on -> Charger side SSR on, current flows from the AMR side via the diode in the Charget side SSR the moment the AMR side SSR turns on, and the BMU detects the overcurrent and The BMU detects the overcurrent and the AMR falls down. As a countermeasure, turn on the AMR-side SSR after turning on the Charger-side SSR. This turns on the AMR-side SSR while the Charger-side potential is high, thus preventing current from flowing from the AMR side.
Countermeasures
This measure works fine whether AMR goes to FastCharge or a conventional charger to charge the battery.