Update to tomcat9 #178
Open
Update to tomcat9 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most contexts this is simple search&replace of 'tomcat8' by 'tomcat9', but the username of the system user has been changed to just 'tomcat' as username 'tomcat9' caused trouble with setfacl. Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE UNTIL YOU ARE SURE YOU WANT TO.
There's a risk, depending on how FCW production is set up (but I don't know details of that), that applying this to production will require extra migration work -> patch should not be merged until you have planned and are ready to do the migration.
However, it would be good to have some more test coverage for this, outside the production, already. Can't go forward with the production preparations with a change that is not well tested. I've not done any vagrant based builds with this, for example.
This also seems to be a dependency for #177