Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multispans #414

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Multispans #414

wants to merge 8 commits into from

Conversation

Kazeya27
Copy link
Collaborator

@Kazeya27 Kazeya27 commented May 12, 2024

  • 数据集配置文件(TrafficStatePointDataset.json)
    { "batch_size": 32, "cache_dataset": true, "num_workers": 0, "pad_with_last_sample": true, "train_rate": 0.6, "eval_rate": 0.2, "scaler": "standardindependc", "load_external": true, "normal_external": false, "ext_scaler": "none", "input_window": 12, "output_window": 12, "add_time_in_day": true, "add_day_in_week": true }
  • 指标
PEMSD8-flow LibCity MultiSPANS
MAE 15.03 15.04
RMSE 24.31 24.33

MultiSPANS的指标是我用他原代码重新跑的

"load_best_epoch": true,
"hyper_tune": false,
"pred_channel_idx":[0],
"outfeat_dim":1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和以前的output_dim的区别是什么?

@@ -0,0 +1,26 @@
{
"embed_dim":64,
"skip_conv_flag" : false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json配置文件的风格规范都统一一下,冒号前无空格,后面一空格,这个pr的所有json都检查一下

@@ -60,5 +61,6 @@
"FOGS",
"RGSL",
"DSTAGNN",
"STPGCN"
"STPGCN",
"MultiSPANS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__init__里面的__all__里面最后一行尽量都加上逗号

@Kazeya27
Copy link
Collaborator Author

该pr为multispans使用按特征维度标准化的版本

# Conflicts:
#	libcity/config/task_config.json
#	libcity/executor/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants