Memory leak in CompressClipData

[jonathanpoelen]

The zip stream in CompressClipData is allocated, but never freed.

static int
CompressClipData(Bytef *dest, uLongf *destLen, Bytef *source, uLong sourceLen)
{
  int ret;
  z_stream *zs = (z_stream*)malloc(sizeof(z_stream));
  // [...]
  // nerver free(zs);
  // [...]
  return ret;
}

The z_stream pointer should not be a pointer and the rest of the function modified accordingly.

[bk138]

True. Happy about a PR :-)

[jonathanpoelen]

I'll do it tomorrow or the day after if I think of it, but I was originally looking for a way to implement file transfer. As I couldn't find it, I went for ultravnc.

You should add static analysis tools like sonar or clang-tidy to your CI. Without any other dependencies, gcc's -fanalyzer works pretty well for C.