Skip to content

Commit

Permalink
remove SimSpecsV2 to not scare people
Browse files Browse the repository at this point in the history
  • Loading branch information
jlnav committed Sep 11, 2023
1 parent 0ace7bd commit 0d92b5c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 16 deletions.
6 changes: 3 additions & 3 deletions libensemble/ensemble.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import importlib
import json
import logging
from typing import Optional, Union
from typing import Optional

import numpy.typing as npt
import tomli
Expand All @@ -10,7 +10,7 @@
from libensemble import logger
from libensemble.executors import Executor
from libensemble.libE import libE
from libensemble.specs import AllocSpecs, ExitCriteria, GenSpecs, LibeSpecs, SimSpecs, SimSpecsV2
from libensemble.specs import AllocSpecs, ExitCriteria, GenSpecs, LibeSpecs, SimSpecs
from libensemble.tools import add_unique_random_streams
from libensemble.tools import parse_args as parse_args_f
from libensemble.tools import save_libE_output
Expand Down Expand Up @@ -248,7 +248,7 @@ class Ensemble:

def __init__(
self,
sim_specs: Optional[Union[SimSpecs, SimSpecsV2]] = SimSpecs(),
sim_specs: Optional[SimSpecs] = SimSpecs(),
gen_specs: Optional[GenSpecs] = GenSpecs(),
exit_criteria: Optional[ExitCriteria] = {},
libE_specs: Optional[LibeSpecs] = None,
Expand Down
6 changes: 3 additions & 3 deletions libensemble/libE.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
import sys
import traceback
from pathlib import Path
from typing import Callable, Dict, Union
from typing import Callable, Dict

import numpy as np

Expand All @@ -129,7 +129,7 @@
from libensemble.manager import LoggedException, WorkerException, manager_main, report_worker_exc
from libensemble.resources.platforms import get_platform
from libensemble.resources.resources import Resources
from libensemble.specs import AllocSpecs, ExitCriteria, GenSpecs, LibeSpecs, SimSpecs, SimSpecsV2, _EnsembleSpecs
from libensemble.specs import AllocSpecs, ExitCriteria, GenSpecs, LibeSpecs, SimSpecs, _EnsembleSpecs
from libensemble.tools.alloc_support import AllocSupport
from libensemble.tools.tools import _USER_SIM_ID_WARNING
from libensemble.utils import launcher
Expand All @@ -143,7 +143,7 @@


def libE(
sim_specs: Union[SimSpecs, SimSpecsV2],
sim_specs: SimSpecs,
gen_specs: GenSpecs,
exit_criteria: ExitCriteria,
persis_info: Dict = {},
Expand Down
11 changes: 1 addition & 10 deletions libensemble/specs.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,6 @@ def check_valid_in(cls, v):
return v


class SimSpecsV2(BaseModel):

fn: Callable
args: list
kwargs: Optional[dict]
outputs: list = []
globus_compute_endpoint: Optional[str] = ""


class GenSpecs(BaseModel):
"""
Specifications for configuring a Generator Function. Equivalent to
Expand Down Expand Up @@ -559,7 +550,7 @@ class _EnsembleSpecs(BaseModel):
libE_specs: LibeSpecs
""" Specifications and options for libEnsemble """

sim_specs: Union[SimSpecs, SimSpecsV2]
sim_specs: SimSpecs
""" Specifications for the simulation function """

gen_specs: Optional[GenSpecs]
Expand Down

0 comments on commit 0d92b5c

Please sign in to comment.