Warning on nested MPI #1025
Merged
Warning on nested MPI #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime and MPI Executor use
|
Is it feasible to do this when we have detected OpenMPI, which we already do. That said there could be other OpenMPI based implementations, but usually I've found everything else works okay. Comment could say MPICH/MPICH-derived as many implementations like Intel MPI are based on MPICH. Better probably, turn it around and say nesting will not work if using Open MPI. |
shuds13
reviewed
Jul 10, 2023
libensemble/libE.py
Outdated
| @@ -386,6 +387,13 @@ def libE_mpi_manager(mpi_comm, sim_specs, gen_specs, exit_criteria, persis_info, | |||
| """Manager routine runs on rank 0.""" | |||
| from libensemble.comms.mpi import MainMPIComm | |||
|
|
|||
| if Executor.executor is not None: | |||
| if isinstance(Executor.executor, MPIExecutor) and libE_specs["comms"] == "mpi": | |||
There was a problem hiding this comment.
As inside libE_mpi_manager - I don't think need to test for comms being "mpi" here.
There was a problem hiding this comment.
Also move below logger set up (which is just below).
…ibensemble into feature/warn_on_nested_mpi
shuds13
approved these changes
Jul 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1015 .