-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mpi_runner_type submit option to executor #1054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, logger prints run_cmd rather than runline.
Tentative consensus for "mpi_runner" |
second tentative consensus for "mpi_runner_type" ? |
jmlarson1
approved these changes
Aug 22, 2023
Think I'm going to keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supplied MPI runner will be used for this submit only.
This is useful in combination with the environment script option, when a different MPI runner may be needed for a particular submit.
The option can be given as a string specifying the MPI runner (e.g. "mpich", "openmpi", "srun", "jsrun", "aprun"), or as a dictionary with the same options as
custom_info
when setting up the executor e.g :{"mpi_runner": "openmpi", "runner_name": "myrunner"}
Provides support for optimas-org/optimas#108
mpi_runner_type
). Could bempi_runner
,env_mpi
,mpi_config
etc...Another change is that when using an environment script, the generated script is logged to ensemble.log rather than the mpirun line itself (which is in the script). This could be either way - any feedback welcome.
Ideally, the mpi_runner_type option would match custom_info in executor init function in name and accepted input.