Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage for CI #1271

Merged
merged 26 commits into from
Apr 11, 2024
Merged

Improve coverage for CI #1271

merged 26 commits into from
Apr 11, 2024

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Mar 21, 2024

Improving coverage as a part of #1268

Improves coverage in libE.py and gets close to full coverage for executor.py, mpi_runner.py and node_resources.py

Includes some code restructuring and minor fixes.

@shuds13 shuds13 self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.38%. Comparing base (786a83b) to head (0d99592).
Report is 55 commits behind head on develop.

Files Patch % Lines
libensemble/executors/mpi_runner.py 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1271       +/-   ##
============================================
+ Coverage    72.64%   94.38%   +21.74%     
============================================
  Files           90       90               
  Lines         8166     8262       +96     
  Branches      1459     1481       +22     
============================================
+ Hits          5932     7798     +1866     
+ Misses        1998      276     -1722     
+ Partials       236      188       -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmlarson1
Copy link
Member

I note that three re-tries in the CI (ubuntu-latest, openmpi, 2.5.2, 3.12, l) have failed in the same place in the test_executor.py unit test on this branch.

https://github.com/Libensemble/libensemble/actions/runs/8413803993/job/23054205905
https://github.com/Libensemble/libensemble/actions/runs/8413803993/job/23054933022
https://github.com/Libensemble/libensemble/actions/runs/8413803993/job/23036575193

@shuds13 shuds13 requested review from jmlarson1 and jlnav April 11, 2024 17:01
@shuds13 shuds13 merged commit 3aa86ad into develop Apr 11, 2024
32 checks passed
@jmlarson1 jmlarson1 deleted the testing/improve_coverage branch April 23, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants