-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tentatively *deprecate* use_persis_return_sim/gen, zero_resource_workers, AllocSpecs.out #1306
Open
jlnav
wants to merge
23
commits into
develop
Choose a base branch
from
refactor/1.3_deprecations
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlnav
changed the title
Tentatively *deprecate* use_persis_return_sim/gen, safe_mode, zero_resource_workers, AllocSpecs.out
Tentatively *deprecate* use_persis_return_sim/gen, ~~safe_mode~~, zero_resource_workers, AllocSpecs.out
May 15, 2024
jlnav
changed the title
Tentatively *deprecate* use_persis_return_sim/gen, ~~safe_mode~~, zero_resource_workers, AllocSpecs.out
Tentatively *deprecate* use_persis_return_sim/gen, zero_resource_workers, AllocSpecs.out
May 17, 2024
…list is actually populated
… renamed for clarity in 2.0
Minor cleanup
capitalization
This reverts commit 939f868.
fixing a capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've worried for a long time that it's impossible to remove things without inconveniencing/warning users manually. For features/capabilities we'd like to remove or dramatically change, we ought to raise DeprecationWarnings for those features, warning of exactly when to expect changes.
I think nowadays users seem to be more likely to request new features, changes, or cleanups at the cost of complete backward compatibility. Plus, thankfully, we're not deleting old releases; I wouldn't mind releasing patches to old releases if requested, similarly to how Python 3.9, 3.10, etc. still get patches.
So based on a handful of conversations, I'll start by proposing the deprecation of those features listed in the title.