Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentatively *deprecate* use_persis_return_sim/gen, zero_resource_workers, AllocSpecs.out #1306

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented May 3, 2024

We've worried for a long time that it's impossible to remove things without inconveniencing/warning users manually. For features/capabilities we'd like to remove or dramatically change, we ought to raise DeprecationWarnings for those features, warning of exactly when to expect changes.

I think nowadays users seem to be more likely to request new features, changes, or cleanups at the cost of complete backward compatibility. Plus, thankfully, we're not deleting old releases; I wouldn't mind releasing patches to old releases if requested, similarly to how Python 3.9, 3.10, etc. still get patches.

So based on a handful of conversations, I'll start by proposing the deprecation of those features listed in the title.

@jlnav jlnav changed the title Tentatively *deprecate* use_persis_return_sim/gen, safe_mode, zero_resource_workers, AllocSpecs.out Tentatively *deprecate* use_persis_return_sim/gen, ~~safe_mode~~, zero_resource_workers, AllocSpecs.out May 15, 2024
@jlnav jlnav changed the title Tentatively *deprecate* use_persis_return_sim/gen, ~~safe_mode~~, zero_resource_workers, AllocSpecs.out Tentatively *deprecate* use_persis_return_sim/gen, zero_resource_workers, AllocSpecs.out May 17, 2024
@jlnav jlnav marked this pull request as ready for review May 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants