Removing dependency caching, some extra.yml dep installs into requirements.txts #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… especially if heffte/ytopt are removed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1420 +/- ##
===========================================
+ Coverage 92.63% 92.75% +0.11%
===========================================
Files 85 85
Lines 7973 7973
Branches 1425 1425
===========================================
+ Hits 7386 7395 +9
+ Misses 387 383 -4
+ Partials 200 195 -5 ☔ View full report in Codecov by Sentry. |
|
I believe we knew this already, but installing gpcam uninstalls numpy 2 |
shuds13
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1403
Plus some other refactors and cleanups.
Its difficult because we have combinations of OS, pydantic version, python version, etc.