Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at allowing decorating of objects with e.g. @output_data(["x"]) #1429

Closed
wants to merge 2 commits into from

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Sep 13, 2024

So these fields show up in docs, but won't affect gen_specs

@jlnav jlnav requested a review from shuds13 September 19, 2024 19:05
@jlnav jlnav marked this pull request as ready for review September 23, 2024 13:59
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (c7d1cb1) to head (77284b1).
Report is 28 commits behind head on docs/asktell.

Additional details and impacted files
@@               Coverage Diff                @@
##           docs/asktell    #1429      +/-   ##
================================================
- Coverage         91.14%   86.46%   -4.68%     
================================================
  Files                91       91              
  Lines              8343     8363      +20     
  Branches           1486     1490       +4     
================================================
- Hits               7604     7231     -373     
- Misses              538      941     +403     
+ Partials            201      191      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav
Copy link
Member Author

jlnav commented Oct 24, 2024

This is probably made redundant/unneeded by the standard requesting that gens explicitly sample over specified variables

@jlnav jlnav closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant