-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml, with pixi as project management tool. add pixi.lock #1459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1459 +/- ##
============================================
+ Coverage 78.43% 90.95% +12.52%
============================================
Files 76 76
Lines 7684 7688 +4
Branches 1140 1141 +1
============================================
+ Hits 6027 6993 +966
+ Misses 1464 534 -930
+ Partials 193 161 -32 ☔ View full report in Codecov by Sentry. |
I'd check the instances of
|
Noting that a very minimal |
More information about https://pixi.sh/latest/features/lockfile/#how-to-use-a-lock-file |
pyproject.toml
Outdated
{name = "Stefan M. Wild"}, {name = "David Bindel"}, | ||
{name = "John-Luke Navarro"}] | ||
|
||
dependencies = ["pip>=24.3.1,<25", "setuptools>=75.1.0,<76", "numpy>=1.21,<3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pip>=24.3.1,<25", "setuptools>=75.1.0,<76",
should prob be below in build systems so separate build from run deps.
default = [] | ||
dev = ["dev"] | ||
|
||
[tool.pixi.feature.dev.dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking lower bounds should be based on what we support. Or if we want to be latest, maybe make a comment to that effect.
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now support Python 3.13 - make sure any updates to setup.py are put in here.
I suggest we dont have lock file in here for now. |
And as Jeff points out above:
Update docs as necessary and other things here. Maybe this is done. Not sure about changing |
Helps address #1444 and #1403
This adds a
pyproject.toml
to replacesetup.py
, which the Python community dramatically encourages.For project management I chose Pixi (https://pixi.sh/latest/):
mpich
as a dev dependency without having to say "install pydantic with pip and mpich with conda".pixi install -e dev
to use thedev
environment. With the lockfile included we're all guaranteed to get a working environment since the lockfile was resolved earlier.This does not mean that users need Pixi, and y'all don't need it either.