Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

add auto hyphenation for all browsers #122

Merged
merged 2 commits into from
Oct 1, 2021
Merged

add auto hyphenation for all browsers #122

merged 2 commits into from
Oct 1, 2021

Conversation

claireolmstead
Copy link
Collaborator

@claireolmstead claireolmstead commented Sep 30, 2021 •
edited
Loading

Purpose

Bug
https://www.pivotaltracker.com/story/show/179596345
If there is a very long string, it was overflowing. We want to hyphenate the string instead.

Solution

Hyphenate and word break in scss. Make compatible for all browsers.

Change summary

  • Add hyphens and word break in scss
  • Apply this same formatting to replies

Steps to Verify

  1. type in a string like "hdhdhddhhdhdhdhdhdhdhhdhdhdbdbdbeuwywguwushsvsvdbjdjdbdbdbdbdbbddbbdbdbdbdbdbdbdbbdbdbbdbdheuwuuehehehehehehjejejejdjdjdhhdhdhdhdhdhdhhhdhdhdhdhdbdbhddhhdhdhhdhdhdhdhdhdhdhdhhdhdhdhdhdhhdhdhdhdhdhhdhdhdhdhhdhdhdhdhdhhdhdhdbdbbdbdbdbdbdbdbbdbdbdbwuueueyyeyeyehehehebdbdbbdbyxjdjfjcjcjvjcivivivivivivivivivicjcjvjcjcjvjvjvjvucicicjcjvivivicicicicicicicicicicicicicicicicicicicicicicucucucjcjcicicicicicicicicufufifdjdiruririridjfjfjfjfjfjdjdjdjdjdjdjdjdjxjxjcjxjcjcjckfkfjfjfjfifififkckckckckckfusyeueu" to new post.
  2. try the same thing in reply.

Additional details / screenshot

Screen Shot 2021-09-30 at 4 42 34 PM

@claireolmstead claireolmstead self-assigned this Sep 30, 2021
@enddynayn
Copy link
Collaborator

👍 baller!

shannonwells
shannonwells reviewed Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

enddynayn
enddynayn approved these changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baller ⛹️‍♀️

@claireolmstead claireolmstead merged commit 603e5de into main Oct 1, 2021
@claireolmstead claireolmstead deleted the bug/long-string-overflow/179596345 branch October 1, 2021 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shannonwells shannonwells shannonwells left review comments

@enddynayn enddynayn enddynayn approved these changes

Assignees

@claireolmstead claireolmstead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claireolmstead @enddynayn @shannonwells