Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Bug/follow unfollow graph state update/179326255 #124

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

claireclark1
Copy link
Collaborator

Purpose

As a user, I want to see the correct follower/following list based on my graph.

Solution

Set and filter the connectionsList in the parent component, ConnectionsList instead of in the child component. We were not initially filtering out the users that did not have the correct status, therefor giving us an inaccurate count in cases such as if you are following then unfollow a user.

Change summary

  • made connectionsList a function that is passed the list that we want to filter.
  • calls connectionsList(followers/following).length to get followers/following count
  • calls connectionsList(currentRelation) to get open connections list and sends that as a prop to ConnectionsListProfiles;

Steps to Verify

  1. Follow a user
  2. unfollow that user
  3. see that the followers/following count is correct
  4. follow that user again
  5. see that followers/following count is correct

@claireclark1 claireclark1 self-assigned this Oct 4, 2021
@claireclark1 claireclark1 force-pushed the bug/Follow-Unfollow-graph-state-update/179326255 branch from 3a5f745 to 21d42b8 Compare October 4, 2021 23:12
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fabuloso.

@claireclark1 claireclark1 force-pushed the bug/Follow-Unfollow-graph-state-update/179326255 branch from 21d42b8 to 86f7430 Compare October 5, 2021 21:51
@claireclark1 claireclark1 merged commit 567030d into main Oct 5, 2021
@claireclark1 claireclark1 deleted the bug/Follow-Unfollow-graph-state-update/179326255 branch October 5, 2021 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants