Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

timestamp + tests #133

Merged
merged 4 commits into from
Oct 19, 2021
Merged

timestamp + tests #133

merged 4 commits into from
Oct 19, 2021

Conversation

claireclark1
Copy link
Collaborator

Purpose

bug
https://www.pivotaltracker.com/story/show/179957621
As a user, I want to see when posts were published.

Solution

check out content.ts and find bug in saving the timestamp to the store.
make sure it appears correctly in the feed
is there a better way to test?

Change summary

  • found bug and fixed if statement to return the correct timestamp.

Steps to Verify

  1. create post
  2. check that timestamp is correct
  3. see posts coming in from other users and on other networks and see that timestamp is correct

Additional details / screenshot

Screen Shot 2021-10-18 at 9 24 42 AM

@claireclark1 claireclark1 self-assigned this Oct 18, 2021
src/components/NewPost.tsx Outdated Show resolved Hide resolved
src/services/content.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... "+ tests?" Weren't you going to add a test?

Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine!

@claireclark1 claireclark1 merged commit 1328991 into main Oct 19, 2021
@claireclark1 claireclark1 deleted the bug/fix-timestamp/179957621 branch October 19, 2021 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants