Removed torus wallet connection #135
Conversation
| To use the Example Client, you must connect with either MetaMask or | ||
| Torus. | ||
| </p> | ||
| <p>To use the Example Client, you must connect with MetaMask</p> | ||
| <Tabs defaultActiveKey="1"> | ||
| <Tabs.TabPane tab="MetaMask" key="1"> |
There was a problem hiding this comment.
Do we want to have the tabs anymore since there is no alternate option?
There was a problem hiding this comment.
Agree, get rid of the tabs.
src/services/wallets/wallet.ts
Outdated
| @@ -22,8 +20,6 @@ export const wallet = (walletType: WalletType): Wallet => { | |||
| switch (walletType) { | |||
| case WalletType.NONE: | |||
There was a problem hiding this comment.
How do we want this to work now? Just thinking about if it is the example client's responsibility to have the option of other wallets, or if we just start deleting code like this and simplify the code to is logged into metamask or no.
There was a problem hiding this comment.
we just start deleting code like this and simplify the code to is logged into metamask or no.
IMO this is the better idea - it will simplify the code and the UI. We need to always keep in mind that this is an example cilent, showing devs how to implement for DSNP, and expect that people will fork it if they want to make changes.
| <div>OR</div> | ||
| <button | ||
| className="LoginModal__loginTorus" | ||
| onClick={() => setWalletType(wallet.WalletType.TORUS)} | ||
| > | ||
| Torus | ||
| </button> |
There was a problem hiding this comment.
After removing the torus button, The user has to press connect then metamask when metamask is the only choice. Should we remove the need for two clicks to connect to metamask?
There was a problem hiding this comment.
Changed my mind, yea I'd say nuke it, make only 1 click
Purpose
https://www.pivotaltracker.com/n/projects/2436354/stories/180031983
We wanted to delete functionality for torus connection as we want to develop the client using metamask for now.
Change summary