-
Notifications
You must be signed in to change notification settings - Fork 4
Re-orient top-level documentation toward new developers #97
Re-orient top-level documentation toward new developers #97
Conversation
Do we want to link to https://libertydsnp.github.io/example-client/ from the README, by the way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A lot of great changes! |
I think that's a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this, I just made a couple of corrections and suggestions.
Suggestion: Even without the changes suggested above, this PR is an improvement (I think) on the docs there currently. How about we merge to The reason I suggest doing it that way is that most of the comments above are about further improvements; they're not bugs in the PR so much as things we could do in addition to this PR. When that's the case, I think merge-and-improve is the best course, because that way the perfect is not being the enemy of the good and we get the stuff that's already done into the mainline of development. Thoughts? |
Also, I just said this to @shannonwells in another channel: "But if you'd like to tweak the doc changes -- which you are far more qualified to do than I am anyway -- +1 and just put the tweaks directly on the branch before merging!" |
I'm good to approve if we only remove or change the info about static-server, which I'm fine doing myself just so we can get it merged. At this point though it'll have to be rebased first. Also happy to do that too given your state of busy-ness right now. |
Ah, you're right -- that's an actual technical mistake in my change that does make things worse :-), good point. Yes, please go for it. |
09be4a7
to
5a2559d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking approved so we can get this merged and continue in another PR with some of the other suggestions (internal and external)
Ah, I merged locally but I can't push to
It merges cleanly, FWIW, so whenever you get a chance it shouldn't take hardly any time, @shannonwells or @claireolmstead. |
* Revamp top-level docs for a newcomer audience * A few tweaks and a correction to purpose of static-server Co-authored-by: shannonwells <shannonwells@users.noreply.github.com>
Purpose
Make the project friendlier to newcomers.
Change summary
Reorganize and lightly rewrite the top-level
README.md
andCONTRIBUTING.md
so that they are aimed more at a newcomer audience -- developers who have heard of DSNP but doesn't know much about it yet. The README now has a table of contents and starts out by stating the purpose of the Example Client and who the intended audience is.