Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary needs to be updated #260

Closed
shannonwells opened this issue Oct 30, 2023 · 0 comments
Closed

Glossary needs to be updated #260

shannonwells opened this issue Oct 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@shannonwells
Copy link
Collaborator

Steps to reproduce

The DSNP Spec Glossary has a bunch of outdated and overly specific references, such as 'Announcement - An item of data, typically an image or note, posted to the blockchain via a "Batch Publication"' and 'Identity Contract - The smart contract used to store a user's delegated public addresses and permissions, see "Contract address"', which should be updated to reflect current reality.

We may wish to add more definitions.

Expected behavior

  • We no longer have an Identity Contract; that was the POC implementation on Ethereum.
  • Announcements don't have to be posted in batches nor do they have to be posted to a blockchain.

Any other comments?
@shannonwells shannonwells added the bug Something isn't working label Oct 30, 2023
@wesbiggs wesbiggs mentioned this issue Jan 4, 2024
Merged
wesbiggs added a commit that referenced this issue Jan 10, 2024
@wesbiggs
DIP-260 Remove outdated entries from the glossary, and clarify others (…
f95e126 
…#270)

Problem
=======
Glossary contains out-of-date terminology no longer associated with the
spec.

Link to GitHub Issue(s): #260 

Solution
========
Removed items that clearly no longer applied.
Edited a few others.

The brevity of the page after these changes arouses suspicion that we
may not benefit much from having a glossary, but perhaps we will find
items to add at a later time.

Change summary:
---------------
- Changes to Glossary page only. I do not believe this warrants a spec
versioning bump.

Co-authored-by: Wes Biggs <wes.biggs@amplica.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shannonwells @wesbiggs