DSNP Operations #215
Merged
DSNP Operations #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
wesbiggs
force-pushed
the
chore/operation-specfication-214
branch
from
f11d247 to
53c371e
Compare
wesbiggs
force-pushed
the
chore/operation-specfication-214
branch
3 times, most recently
from
032891e to
3ce5b21
Compare
wilwade
commented
Dec 9, 2022
wesbiggs
force-pushed
the
chore/operation-specfication-214
branch
3 times, most recently
from
6e9f9bc to
2b6c14a
Compare
wilwade
commented
Jan 6, 2023
wilwade
commented
Jan 6, 2023
wilwade
commented
Jan 6, 2023
wesbiggs
force-pushed
the
chore/operation-specfication-214
branch
from
2b6c14a to
e1dde24
Compare
aramikm
reviewed
Jan 6, 2023
wesbiggs
force-pushed
the
chore/operation-specfication-214
branch
from
ed5fb35 to
5c605f2
Compare
|
Incorporated suggestions from @jeanettedepatie. |
shannonwells
approved these changes
Jan 17, 2023
shannonwells
requested changes
Jan 18, 2023
wesbiggs
force-pushed
the
chore/operation-specfication-214
branch
from
e186969 to
0ce7b4d
Compare
shannonwells
approved these changes
Jan 19, 2023
| "blockchain", | ||
| "archiveEntryID", | ||
| "asynchronously", | ||
| "(a )?blockchain", |
There was a problem hiding this comment.
Non-blocking, but this line should be removed.
Suggested change
| "(a )?blockchain", |
There was a problem hiding this comment.
You would think so, right? I actually filed a bug for yaspeller on this: hcodes/yaspeller#187 (unfortunately yaspeller as a project seems to have gone dark about the same time Russia invaded Ukraine).
wesbiggs
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The specification lacks formal details on the operations a compliant implementation should provide.
Link to GitHub Issue(s): Closes #214
Solution
This PR adds Operations tables to the Identity and Announcements pages (which are the two areas where operations have thus far been specified). For each operation, we provide a name, the principal(s) who will be invoking the operation, the inputs, and the expected outputs or state changes.
Note that this is not a spec version change, but rather a clarification of the existing spec.
Change summary:
Steps to Verify:
npm run build) and preview in browser to ensure there are no formatting issues.Screenshots (optional):
N/A