DSNP spec #176853320 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
requested review from
rosalinekarr,
Ajaxan,
aneyzberg,
claireolmstead and
wilwade
shannonwells
force-pushed
the
feat/dsnp-spec-#176853320
branch
from
d6c9f3c to
add706e
Compare
wilwade
reviewed
Feb 17, 2021
There was a problem hiding this comment.
@shannonwells This is a great start. I added some comments, but many of them may just need to be separate PRs.
wilwade
reviewed
Feb 17, 2021
|
WIth this many comments I feel this should be put back to draft. |
rlaferla
pushed a commit
that referenced
this pull request
Sep 12, 2022
* Make the Parquet Tests reusable * Update Announcement * Reply Announcement * Reaction Announcement * Tombstone Announcement * Profile Announcement * announcementType should be INT32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSNP spec proposal, closes #176853320