Skip to content

Fix generic type arguments issue. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "com.chebanovdd.unityuxmlgenerator",
"displayName": "Unity Uxml Generator",
"author": { "name": "ChebanovDD", "url": "https://github.com/ChebanovDD" },
"version": "0.0.5",
"version": "0.0.6",
"unity": "2018.4",
"description": "The Unity Uxml Generator allows you to generate 'UxmlFactory' and 'UxmlTraits' source code for a custom 'VisualElement'. Just mark elements with [UxmlElement] and [UxmlAttribute] attributes.",
"keywords": [ "uxml", "source", "generator" ]
Expand Down
6 changes: 3 additions & 3 deletions src/UnityUxmlGenerator/Captures/UxmlTraitsCapture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ public UxmlTraitsCapture(ClassDeclarationSyntax @class, TypeSyntax baseClassType
public TypeSyntax BaseClassType { get; }
public List<(PropertyDeclarationSyntax Property, AttributeSyntax Attribute)> Properties { get; }

public string GetBaseClassName(out TypeSyntax? genericTypeSyntax)
public string GetBaseClassName(out IEnumerable<TypeSyntax>? genericTypeArguments)
{
if (BaseClassType is GenericNameSyntax genericNameSyntax)
{
genericTypeSyntax = genericNameSyntax.TypeArgumentList.Arguments[0];
genericTypeArguments = genericNameSyntax.TypeArgumentList.Arguments;
return genericNameSyntax.Identifier.Text;
}

genericTypeSyntax = default;
genericTypeArguments = default;

if (BaseClassType is IdentifierNameSyntax identifierNameSyntax)
{
Expand Down
79 changes: 79 additions & 0 deletions src/UnityUxmlGenerator/Extensions/StringBuilderExtensions.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
using System.Text;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp.Syntax;

namespace UnityUxmlGenerator.Extensions;

public static class StringBuilderExtensions
{
public static void AppendGenericString(this StringBuilder stringBuilder, GeneratorExecutionContext context,
IEnumerable<TypeSyntax> genericTypeArguments)
{
var isFirstArgument = true;

stringBuilder.Append('<');

foreach (var genericClassTypeSyntax in genericTypeArguments)
{
if (isFirstArgument == false)
{
stringBuilder.Append(", ");
}

isFirstArgument = false;

switch (genericClassTypeSyntax)
{
case PredefinedTypeSyntax predefinedTypeSyntax:
AppendPredefinedTypeSyntax(stringBuilder, predefinedTypeSyntax);
break;

case IdentifierNameSyntax identifierNameSyntax:
AppendIdentifierNameSyntax(stringBuilder, context, identifierNameSyntax);
break;

case GenericNameSyntax genericTypeSyntax:
AppendGenericTypeSyntax(stringBuilder, context, genericTypeSyntax);
break;
}
}

stringBuilder.Append('>');
}

private static void AppendPredefinedTypeSyntax(StringBuilder stringBuilder,
PredefinedTypeSyntax predefinedTypeSyntax)
{
stringBuilder.Append(predefinedTypeSyntax.Keyword.Text);
}

private static void AppendIdentifierNameSyntax(StringBuilder stringBuilder, GeneratorExecutionContext context,
IdentifierNameSyntax identifierNameSyntax)
{
var genericClassName = identifierNameSyntax.Identifier.Text;
var genericClassNamespace = identifierNameSyntax.GetTypeNamespace(context);

stringBuilder.Append("global::");
stringBuilder.Append(genericClassNamespace);
stringBuilder.Append('.');
stringBuilder.Append(genericClassName);
}

private static void AppendGenericTypeSyntax(StringBuilder stringBuilder, GeneratorExecutionContext context,
GenericNameSyntax genericTypeSyntax)
{
var genericClassName = genericTypeSyntax.Identifier.Text;
var genericClassNamespace = genericTypeSyntax.GetTypeNamespace(context);

if (string.IsNullOrWhiteSpace(genericClassNamespace) == false)
{
stringBuilder.Append("global::");
stringBuilder.Append(genericClassNamespace);
stringBuilder.Append('.');
}

stringBuilder.Append(genericClassName);

AppendGenericString(stringBuilder, context, genericTypeSyntax.TypeArgumentList.Arguments);
}
}
9 changes: 8 additions & 1 deletion src/UnityUxmlGenerator/Extensions/SyntaxNodeExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ when qualifiedNameSyntax.Right.Identifier.Text.Contains(attributeName):

public static string? GetTypeNamespace(this SyntaxNode syntaxNode, GeneratorExecutionContext context)
{
return GetTypeSymbol(syntaxNode, context)?.ContainingNamespace.ToString();
var containingNamespace = GetTypeSymbol(syntaxNode, context)?.ContainingNamespace;

if (containingNamespace is null || containingNamespace.IsGlobalNamespace)
{
return null;
}

return containingNamespace.ToString();
}
}
23 changes: 9 additions & 14 deletions src/UnityUxmlGenerator/UxmlGenerator.Traits.cs
Original file line number Diff line number Diff line change
Expand Up @@ -133,28 +133,23 @@ private static StatementSyntax GetAttributeValueAssignmentStatement(string prope

private static string GetBaseClassName(GeneratorExecutionContext context, UxmlTraitsCapture capture)
{
var baseClassName = capture.GetBaseClassName(out var genericClass);
var baseClassName = capture.GetBaseClassName(out var genericTypeArguments);
var baseClassNamespace = capture.BaseClassType.GetTypeNamespace(context);

if (genericClass is null)
if (genericTypeArguments is null)
{
return $"global::{baseClassNamespace}.{baseClassName}";
}

if (genericClass is PredefinedTypeSyntax predefinedTypeSyntax)
{
return $"global::{baseClassNamespace}.{baseClassName}<{predefinedTypeSyntax.Keyword.Text}>";
}
var stringBuilder = new StringBuilder();

if (genericClass is IdentifierNameSyntax customTypeSyntax)
{
var genericClassName = customTypeSyntax.Identifier.Text;
var genericClassNamespace = customTypeSyntax.GetTypeNamespace(context);

return $"global::{baseClassNamespace}.{baseClassName}<global::{genericClassNamespace}.{genericClassName}>";
}
stringBuilder.Append("global::");
stringBuilder.Append(baseClassNamespace);
stringBuilder.Append('.');
stringBuilder.Append(baseClassName);
stringBuilder.AppendGenericString(context, genericTypeArguments);

return string.Empty;
return stringBuilder.ToString();
}

private static bool TryGetUxmlAttributeInfo(GeneratorExecutionContext context, PropertyDeclarationSyntax property,
Expand Down
1 change: 1 addition & 0 deletions src/UnityUxmlGenerator/UxmlGenerator.Widgets.cs
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ private static FieldDeclarationSyntax FieldWidget(
{
var variableDeclaration = VariableDeclarator(Identifier(identifier));

// TODO: Change to BaseObjectCreationExpressionSyntax.
if (initializer is not null)
{
variableDeclaration = variableDeclaration.WithInitializer(EqualsValueClause(ImplicitObjectCreationExpression()
Expand Down