Luton has moved to Luci #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haringey has moved to Enterprise (LibrariesHacked#23)
East Lothian has moved to Spydus (LibrariesHacked#24)
Falkirk has moved to Spydus (LibrariesHacked#25)
Merge from LibrariesHacked
|
Hi Chris Thanks! And yes, I always tend to set policies in GitHub to do squash commits whenever merging to main. I just find that leads to a cleaner main but that's only really the case when people are committing often on feature branches and there's a policy of a single branch per feature. I've done normal merge this time as the history looks useful! So I'll probably just continue to do that and only squash merge on single-feature branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made accordingly and tests pass. Sutton also still working after a few tweaks to the Luci code.
Coventry still broken - their catalogue has been down for several weeks with a promise of being back online by the beginning of March. It's still not back!
I've noticed that my commits keep showing up again and again in each PR, by the way. Is that because you're squashing them during the PR..?