Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#307 Replace dashes with underscores (13-looking-up-data.md) #310

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

mahdi-robbani
Copy link
Contributor

Addresses Issue #307

Column names with a dash in them have been replaced with underscores.

@github-actions
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@ostephens ostephens merged commit 1aef633 into LibraryCarpentry:main Aug 28, 2023
3 checks passed
@ostephens
Copy link
Contributor

Looks great @mahdi-robbani - thanks very much!

Just for clarity - did you check through all episodes for column naming or just 13/looking up data?

@ostephens ostephens self-requested a review August 28, 2023 16:13
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
Auto-generated via {sandpaper}
Source  : 1aef633
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-08-28 16:13:12 +0000
Message : Merge pull request #310 from mahdi-robbani/main

#307 Replace dashes with underscores (13-looking-up-data.md)
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
Auto-generated via {sandpaper}
Source  : a2e24f0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-28 16:14:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 1aef633
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-08-28 16:13:12 +0000
Message : Merge pull request #310 from mahdi-robbani/main

#307 Replace dashes with underscores (13-looking-up-data.md)
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
Auto-generated via {sandpaper}
Source  : a2e24f0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-28 16:14:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 1aef633
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-08-28 16:13:12 +0000
Message : Merge pull request #310 from mahdi-robbani/main

#307 Replace dashes with underscores (13-looking-up-data.md)
@mahdi-robbani
Copy link
Contributor Author

Just 13-looking-up-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants