Make request method configurable #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,7 @@ | |||
| $conf['settings']['recaptcha']['enabled'] = 'false'; | |||
| $conf['settings']['recaptcha']['public.key'] = ''; | |||
| $conf['settings']['recaptcha']['private.key'] = ''; | |||
| $conf['settings']['recaptcha']['request.method'] = 'curl'; // options are curl, post or socket. default: post | |||
There was a problem hiding this comment.
This basically makes the default curl. Why not make it post?
There was a problem hiding this comment.
Post uses file_get_contents which requires the option allow_url_fopen to be enabled. Because this could cause security issues and therefore it might not be enabled by default. On the other side I can hardly imagine a PHP installation without CURL.
There was a problem hiding this comment.
I made post the default anyway so, that existing installations have the same behavior as before, when the setting is not added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default request method of recaptcha is post. This uses the method
file_get_contentsto execute the request. This might be blocked.This PR makes the request method configurable. The default is still post. However I changed it to curl in the default config file.
I also fixed the logging.