Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type casting inconsistency #174

Closed
ManSoSec opened this issue Dec 11, 2019 · 1 comment
Closed

Type casting inconsistency #174

ManSoSec opened this issue Dec 11, 2019 · 1 comment
Assignees
@rurban
Milestone
0.10

Comments

@ManSoSec
Copy link

libredwg/src/decode.c

Line 2552 in 785df5f

while ((int)(hdl_dat.byte - startpos) < section_size)

libredwg/src/decode_r2007.c

Line 1594 in 785df5f

while (hdl_dat.byte - startpos < section_size)

Is a type casting (int) missed?
@rurban rurban self-assigned this Dec 25, 2019
@rurban
Copy link
Contributor

rurban commented Dec 26, 2019

We should rather zero-extend to long both sides here, to avoid overflows. Thanks. Done in 631bbac

rurban added a commit that referenced this issue Dec 26, 2019
@rurban
Type casting inconsistency #174
631bbac 
Avoid overflows by casting to the larger type, zero-extended
@rurban rurban closed this as completed Dec 26, 2019
@rurban rurban added this to the 0.10 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rurban rurban

Labels
None yet
Projects
None yet
Milestone
0.10
Development

No branches or pull requests
2 participants
@rurban @ManSoSec