Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant build and package.properties improvements #129

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

prrvchr
Copy link
Contributor

@prrvchr prrvchr commented Jan 15, 2025

This PR is supposed to fix issue #127

  • Class-Path has been added to the MANIFEST.MF file.
  • No other archive is created when generating the build.xml file.

In addition to these two fixes, the management of the package.properties file has been revised to correct the following problems:

  • When deserializing (ie: reading the package.properties file), if any resources are missing or modified, a message will be logged and the file marked as modified (ie: isDirty() returns true).
  • When saving if there are any pending changes (ie: if you used the text editor or when opening missing files are displayed) then the text editor will be reloaded.
  • A specific listener for refreshing the widget (ie: ContainerCheckedTreeViewer) has been implemented.
  • All listeners loaded on initialization are now removed during dispose().
  • Hidden files and/or folders (ie: starting with dot) management is now supported.
  • It is now possible to include a folder in the selection if it is empty (ie: no visible members).

I must be forgetting things but I remain available for any information and thank in advance for the reviewer.

@prrvchr prrvchr force-pushed the bug#127 branch 3 times, most recently from efd001f to 9e90178 Compare January 15, 2025 22:56
@smehrbrodt smehrbrodt merged commit 541e80d into LibreOffice:master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ant build needs improvements
2 participants