Merge pull request #172 from Kindrat/master

Code reformat and checkstyle

checkstyle.xml

@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+        "https://checkstyle.org/dtds/configuration_1_3.dtd">
+
+<!--
+  Checkstyle configuration that checks the sun coding conventions from:
+    - the Java Language Specification at
+      https://docs.oracle.com/javase/specs/jls/se11/html/index.html
+    - the Sun Code Conventions at https://www.oracle.com/technetwork/java/codeconvtoc-136057.html
+    - the Javadoc guidelines at
+      https://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
+    - the JDK Api documentation https://docs.oracle.com/en/java/javase/11/
+    - some best practices
+  Checkstyle is very configurable. Be sure to read the documentation at
+  http://checkstyle.sourceforge.net (or in your downloaded distribution).
+  Most Checks are configurable, be sure to consult the documentation.
+  To completely disable a check, just comment it out or delete it from the file.
+  Finally, it is worth reading the documentation.
+-->
+
+<module name="Checker">
+
+    <!--
+        If you set the basedir property below, then all reported file
+        names will be relative to the specified directory. See
+        https://checkstyle.org/5.x/config.html#Checker
+        <property name="basedir" value="${basedir}"/>
+    -->
+
+    <module name="TreeWalker">
+        <property name="cacheFile" value="target/cachefile"/>
+        <module name="UnusedImports">
+            <property name="processJavadoc" value="true"/>
+        </module>
+    </module>
+</module>

openpdf/src/main/java/com/lowagie/text/pdf/PdfStamper.java

@@ -53,7 +53,6 @@
 import java.io.OutputStream;
 import java.security.SignatureException;
 import java.util.Calendar;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import com.lowagie.text.error_messages.MessageLocalization;

pdf-html/src/main/java/com/lowagie/text/html/SAXmyHtmlHandler.java

@@ -120,7 +120,7 @@ public SAXmyHtmlHandler(DocListener document, HashMap htmlTags) {
      * 
      * @param uri
      *            the Uniform Resource Identifier
-     * @param lname
+     * @param localName
      *            the local name (without prefix), or the empty string if
      *            Namespace processing is not being performed.
      * @param name
@@ -129,7 +129,7 @@ public SAXmyHtmlHandler(DocListener document, HashMap htmlTags) {
      *            the list of attributes
      */
 
-    public void startElement(String uri, String lname, String name,
+    public void startElement(String uri, String localName, String name,
             Attributes attrs) {
         // System.err.println("Start: " + name);
 
@@ -274,4 +274,4 @@ public void endElement(String uri, String lname, String name) {
         // suggestion by Ken Auer
         handleEndingTags(name);
     }
-}
+}

pdf-html/src/main/java/com/lowagie/text/html/simpleparser/IncTable.java

@@ -49,7 +49,6 @@
 
 import java.util.*;
 
-import com.lowagie.text.pdf.PdfCell;
 import com.lowagie.text.pdf.PdfPCell;
 import com.lowagie.text.pdf.PdfPTable;
 

pdf-toolbox/src/main/java/com/lowagie/toolbox/plugins/ConcatN.java

@@ -38,7 +38,6 @@
 import java.io.File;
 import java.io.FileOutputStream;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 

pdf-toolbox/src/test/java/com/lowagie/examples/fonts/styles/ExtraStyles.java

@@ -23,7 +23,6 @@
 
 import java.io.ByteArrayOutputStream;
 
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 /**
@@ -69,4 +68,4 @@ void testUnderlineAndStrikeThrough() throws Exception {
         }
 
     }
-}
+}

pdf-toolbox/src/test/java/com/lowagie/examples/general/HelloWorldPdf.java

@@ -23,7 +23,6 @@
 
 import java.io.ByteArrayOutputStream;
 
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 /**
@@ -72,4 +71,4 @@ void testHelloWorld() throws Exception {
         }
 
     }
-}
+}

pdf-toolbox/src/test/java/com/lowagie/examples/objects/images/AwtImage.java

@@ -23,7 +23,6 @@
 import java.awt.*;
 import java.io.ByteArrayOutputStream;
 
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 /**

pdf-xml/pom.xml

@@ -21,5 +21,9 @@
             <artifactId>openpdf</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs</artifactId>
+        </dependency>
     </dependencies>
 </project>