lift TrueTypeFontUnicode.includeCidSet flag up to BaseFont to make it publicly accessible (#1041) #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
this is a follow-up to #1045 which added a new
TrueTypeFontUnicode.includeCidSet
flag.but due to the class
TrueTypeFontUnicode
being package private, that class cannot be used directly in consumer application code (i.e. to downcastBaseFont
), meaning the flag is not accessible.this commit lifts the flag along with its getter/setter up to
BaseFont
to make it publicly accessible.Related Issue: #1041
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
n/a
Testing details
@andreasrosdal sorry for not spotting this right away.. missed it as the unit-test resides in the same package..
i hope this approach makes sense to you, too - i did not want to change
TrueTypeFontUnicode
visibility. added some javadoc.