Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lift TrueTypeFontUnicode.includeCidSet flag up to BaseFont to make it publicly accessible (#1041) #1046

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

zyro23
Copy link
Contributor

@zyro23 zyro23 commented Feb 13, 2024

Description of the new Feature/Bugfix

this is a follow-up to #1045 which added a new TrueTypeFontUnicode.includeCidSet flag.
but due to the class TrueTypeFontUnicode being package private, that class cannot be used directly in consumer application code (i.e. to downcast BaseFont), meaning the flag is not accessible.
this commit lifts the flag along with its getter/setter up to BaseFont to make it publicly accessible.

Related Issue: #1041

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to the added feature

Compatibilities Issues

n/a

Testing details

@andreasrosdal sorry for not spotting this right away.. missed it as the unit-test resides in the same package..
i hope this approach makes sense to you, too - i did not want to change TrueTypeFontUnicode visibility. added some javadoc.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@andreasrosdal andreasrosdal merged commit 74d0e1a into LibrePDF:master Feb 13, 2024
8 of 9 checks passed
@andreasrosdal
Copy link
Contributor

Thank you. More pull requests to improve OpenPDF is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants