Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1059 When converting HTML to PDF, font size specified in % is interpreted as pixels #1069

Conversation

RadekWikturna
Copy link
Contributor

Description of the new Feature/Bugfix

Added support for font size specified in %.

Related Issue: #1059

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug

Compatibilities Issues

none, I hope

Testing details

Run the FontSizeTest. See also the generated 'Font Size.pdf'

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@RadekWikturna
Copy link
Contributor Author

The pull request if for the 1.3-java8 branch because right now we need to use Java 8. But eventually, the same fix should go to the main branch.

@asturio asturio added this to the 1.3.42 milestone Feb 22, 2024
@asturio asturio self-assigned this Feb 22, 2024
@asturio asturio merged commit b66bd5f into LibrePDF:1.3-java8 Feb 22, 2024
3 checks passed
@asturio
Copy link
Member

asturio commented Feb 22, 2024

Nice. Thank you for the test!

@RadekWikturna RadekWikturna deleted the #1059_When_converting_HTML_to_PDF,_font_size_specified_in_%_is_interpreted_as_pixels branch February 22, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When converting HTML to PDF, font size specified in % is interpreted as pixels
2 participants