#156: Throw Exception if PdfWriter.close() is called directly #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throw an IllegalStateException if PdfWriter.close() is called before Document.close() is called. - Delete old *.lng files in src/main/java - Update *.lng files in src/main/resources - BoyScout rule in PdfWriter
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
|
@andreasrosdal maybe you want to take a look? |
- Codacy Issues
|
asturio
deleted the
feature/156-exception-if-pdfwriter.close-called-before-document.close
branch
asturio
added a commit
that referenced
this pull request
Feb 26, 2024
* #156: Throw Exception if PdfWriter.close() is called directly - Throw an IllegalStateException if PdfWriter.close() is called before Document.close() is called. - Delete old *.lng files in src/main/java - Update *.lng files in src/main/resources - BoyScout rule in PdfWriter * #156: Throw Exception if PdfWriter.close() is called directly - Codacy Issues (cherry picked from commit 6c675f7)
asturio
added a commit
that referenced
this pull request
Feb 26, 2024
* #156: Throw Exception if PdfWriter.close() is called directly - Throw an IllegalStateException if PdfWriter.close() is called before Document.close() is called. - Delete old *.lng files in src/main/java - Update *.lng files in src/main/resources - BoyScout rule in PdfWriter * #156: Throw Exception if PdfWriter.close() is called directly - Codacy Issues (cherry picked from commit 6c675f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature
Calling PdfWriter.close() is actually not needed. An Exception will be thrown if this is done before Document.close() is called.
Calling PdfWriter.close() afterwards should be harmless.
Related Issue: #156
Unit-Tests for the new Feature
Compatibilities Issues
As PdfWriter.close() before Document.close() will produce incomplete PDFs, throwing an Exception will just be good for existing Wrong code.