Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted changes meant for 2.0.0 and restored Java8 compatibility #1086

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Reverted changes meant for 2.0.0 and restored Java8 compatibility #1086

merged 4 commits into from
Mar 4, 2024

Conversation

Lonzak
Copy link
Contributor

@Lonzak Lonzak commented Feb 28, 2024

  1. Reverted be38865 to maintain compatibility with iText. This kind of changes will be done in 2.0.0 onwards.

  2. Commit 63a678d broke java8 compatibility

…f changes will be done in 2.0.0 onwards.

2) Commit 63a678d  broke java8 compatibility
@RadekWikturna
Copy link
Contributor

Can you please fix the problems reported by Codacy?

Copy link
Member

@asturio asturio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lonzak ,

if you have time take a look at my marking. If not, I can merge this and try to check if these are really ok, in a "cleanup" commit.

@asturio
Copy link
Member

asturio commented Feb 29, 2024

Looking tomorrow again, and merging.

@Lonzak
Copy link
Contributor Author

Lonzak commented Mar 1, 2024

I have to admit I didn't check the changes from the commit ( be38865) in detail - I just used the revert function of my git tool...
Parts of the changes like using isEmpty() and so on is of course better. And I would also remove the ITXT variable from PdfName...

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Lonzak
Copy link
Contributor Author

Lonzak commented Mar 1, 2024

Ok I did commit the changes.

By the way: Should we do something about the failing test in

PdfDocumentCJKExtensionTest.generateDocumentsWithCJKExtension
fonts/TakaoMjFonts/TakaoMjMincho.ttf

The font is missing.
We should either comment the test with @ignore or add the font...

@asturio
Copy link
Member

asturio commented Mar 2, 2024

The code is not compiling. I think the given test class was removed.

The missing fonts are huge, so I would just delete the test or add an @disabled there.

@asturio
Copy link
Member

asturio commented Mar 2, 2024

I think for this PR the Codacy could be ignored.

@asturio asturio added this to the 1.3.42 milestone Mar 3, 2024
@asturio asturio merged commit 3785302 into LibrePDF:1.3-java8 Mar 4, 2024
2 of 5 checks passed
@asturio asturio linked an issue Mar 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backward compatility issues with iText 2.1.7.
3 participants