-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverted changes meant for 2.0.0 and restored Java8 compatibility #1086
Conversation
…f changes will be done in 2.0.0 onwards. 2) Commit 63a678d broke java8 compatibility
Can you please fix the problems reported by Codacy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Lonzak ,
if you have time take a look at my marking. If not, I can merge this and try to check if these are really ok, in a "cleanup" commit.
openpdf/src/main/java/com/lowagie/text/pdf/MappedRandomAccessFile.java
Outdated
Show resolved
Hide resolved
openpdf/src/main/java/com/lowagie/text/pdf/PdfCopyFieldsImp.java
Outdated
Show resolved
Hide resolved
openpdf/src/main/java/com/lowagie/text/pdf/hyphenation/SimplePatternParser.java
Outdated
Show resolved
Hide resolved
openpdf/src/test/java/com/lowagie/text/pdf/SimpleBookmarkTest.java
Outdated
Show resolved
Hide resolved
Looking tomorrow again, and merging. |
I have to admit I didn't check the changes from the commit ( be38865) in detail - I just used the revert function of my git tool... |
Quality Gate passedIssues Measures |
Ok I did commit the changes. By the way: Should we do something about the failing test in
The font is missing. |
The code is not compiling. I think the given test class was removed. The missing fonts are huge, so I would just delete the test or add an @disabled there. |
I think for this PR the Codacy could be ignored. |
Reverted be38865 to maintain compatibility with iText. This kind of changes will be done in 2.0.0 onwards.
Commit 63a678d broke java8 compatibility