fix for invalid ecdsa oids for signatures #1105
Conversation
Lonzak
changed the title
|
@mkl-public Code review appreciated :-) |
There was a problem hiding this comment.
The changes in ExceptionConverter are unrelated (and IMO mostly unnecessary, but that is indeed a matter of opinion). Nonetheless, they don't break anything either.
The PdfPKCS7 changes are pivotal and look appropriate. You may consider adding tests for at least a representative selection of the Algorithms.
Also consider the Codacy remarks, they are meant to introduce a common style which in turn improves readability.
|
|
Fixed the codacy issues. |
|
Looks good. Are you ready with your changes, @Lonzak ? |
|
Merged that. If you want, you may add some tests for this. |
Corrected the OIDs for several algorithms (RSA, DSA and ECDSA) when signing with openPDF.