Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing wiki examples #1139

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

jabhatfield
Copy link

Add missing wiki examples

  • "Header and footer" wiki example was not in the pdf-toolbox. I have tidied it up and added it.
  • "Signing" wiki example did not exist. I have created one.

If they look ok I will update the wiki to reference them.

Testing details

Run the main methods as per the other examples in the pdf-toolbox.

Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@asturio
Copy link
Member

asturio commented Apr 10, 2024

Looks nice. I find it is allways better to have examples as code, so they change if the library change. You can update the Wiki, if you want.

@asturio asturio merged commit cc98249 into LibrePDF:master Apr 10, 2024
7 checks passed
@jabhatfield
Copy link
Author

Wiki updated:

https://github.com/LibrePDF/OpenPDF/wiki/Header-and-Footer
https://github.com/LibrePDF/OpenPDF/wiki/Signing

@asturio please can you check it's ok? if so I will update wiki entries 1-4 and 7 in a similar way, to reference current examples. I agree with referencing code directly :)

@asturio
Copy link
Member

asturio commented Apr 10, 2024

That is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants