Skip to content

Fix setting margin on open document #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreasrosdal merged 1 commit into from
May 14, 2025
Merged

Fix setting margin on open document #1283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions openpdf/src/main/java/com/lowagie/text/pdf/PdfDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ public boolean newPage() {
lastElementType = -1;
if (isPageEmpty()) {
setNewPageSizeAndMargins();
resetText(true);
return false;
}
if (!open || close) {
Expand Down Expand Up @@ -1124,6 +1125,16 @@ public void resetFooter() {

// [C4] Page labels

private void resetText(boolean move) {
text = new PdfContentByte(writer);
text.reset();
text.beginText();
textEmptySize = text.size();
if (move) {
text.moveText(left(), top());
}
}

/**
* Initializes a page.
* <p>
Expand All @@ -1141,10 +1152,7 @@ protected void initPage() throws DocumentException {

writer.resetContent();
graphics = new PdfContentByte(writer);
text = new PdfContentByte(writer);
text.reset();
text.beginText();
textEmptySize = text.size();
resetText(false);

markPoint = 0;
setNewPageSizeAndMargins();
Expand Down