static analysis fixes.

[chas678]

Apologies for adding such a large PR. These are automatic refactorings that should not affect the code function; only amend the newer code style of Java 5,7 or 8 where possible.

A couple of minor anomalies/bugs were exposed whilst working through these, no fixes yet just annotated with TODO: comments.

[andreasrosdal]

Thanks!

What did you use to create this?
Does it break the Api in any way?
Why did you remove dependencies from the pom file?

[chas678]

Hi I used Jetbrains IntelliJ idea community edition “analyse” tool/menu item , and applied some of it’s suggested safe automatic refactorings. There are no API changes ( but there is a small chance of unexpected side effects - for example there was one manual loop over a collection list that did break as it modified the list whilst looping, so I left that unmodified with a TODO comment to look at it later). I moved the test dependencies up to the parent Pom to avoid repetition, as I thought they would all be used by each sub module for it”a tests, which in turn would inherit the parent Pom dependencies . I ran all the tests (and made some of those that require files to be location independent so I could run them in the IDE). The test coverage is a little low so was thinking I could perhaps spend a little time soon on adding to the unit tests, to get better confidence regarding any problems being caught by tests. Please let me know if you spot anything that’s not correct. Regards, Chris

…

Sent from my iPhone

On 10 Mar 2019, at 15:44, Andreas Rosdal ***@***.***> wrote: Thanks! What did you use to create this? Does it break the Api in any way? Why did you remove dependencies from the pom file? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[andreasrosdal]

Looks good. Thanks for your contribution to the project.