Make Document and PdfWriter compatible with try-with-resources #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes Document and PdfWriter implement AutoCloseable interface either directly or indirectly. PdfWriter was made implement Closeable as Closeable is an I/O interface and PdfWriter already deals with I/O. This is similar to what PdfReader already does. Document on the other hand doesn't do I/O so it was made to implement AutoCloseable interface. Additionally all `close` methods have been marked with `@Override` annotation.
|
Thanks, this is good. By the way, what are you using OpenPDF for? |
|
Adding translation of pages (shift page content a little bit left/right) using affine transforms. I didn't have any PDF experience though so it took a little bit more time than I expected but at the end it looks good 👍 except I could't use try-with-resources for Document and PdfWriter so I thought why not make a PR here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
This change makes Document and PdfWriter implement AutoCloseable interface either directly or indirectly. PdfWriter was made implement Closeable as Closeable is an I/O interface and PdfWriter already deals with I/O. This is similar to what PdfReader already does.
Document on the other hand doesn't do I/O so it was made to implement AutoCloseable interface.
Additionally all
closemethods have been marked with@Overrideannotation.