Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings and cleanup #166

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Refactorings and cleanup #166

merged 1 commit into from
Apr 2, 2019

Conversation

Kindrat
Copy link
Contributor

@Kindrat Kindrat commented Mar 31, 2019

Removed some dead code, unified formatting, removed some duplication, added null-safety warnings

@andreasrosdal
Copy link
Contributor

@Kindrat Please provide some more information about this pull-request.

-Why are you proposing this change?
-Will this change break the API for existing users of OpenPDF or iText 2.x/4.x?
-What are you using OpenPDF for today?

Thanks for your contribution to this project!

@rtfarte @chas678 @fvbassi Can you please review this PR also?

@andreasrosdal andreasrosdal added the pr-needs-review This pull request needs a good code review label Apr 2, 2019
@Kindrat
Copy link
Contributor Author

Kindrat commented Apr 2, 2019

@andreasrosdal I've seen librepdf in project shelter and have some time, so wanted to help. I mostly start with refactorings on new projects to get more familiar with codebase.

This change should not break anything, if only I have not made some accidental change. In my next PR I'll fix some deprecated method usages and will migrate raw types to generics. Actually that's already in my local changes, just waiting.

@andreasrosdal andreasrosdal merged commit 9e2dd09 into LibrePDF:master Apr 2, 2019
@andreasrosdal
Copy link
Contributor

Thanks for your contribution to OpenPDF.

@Kindrat
Copy link
Contributor Author

Kindrat commented Apr 2, 2019

accumulate method was deleted as was private and unused?

yes

@Kindrat Kindrat mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasrosdal andreasrosdal andreasrosdal left review comments

@chas678 chas678 chas678 left review comments

@rtfarte rtfarte rtfarte left review comments

Assignees
No one assigned
Labels
pr-needs-review This pull request needs a good code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kindrat @andreasrosdal @rtfarte @chas678