Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More null-check annotations, minor code cleanup #178

Merged
merged 1 commit into from
Apr 6, 2019
Merged

More null-check annotations, minor code cleanup #178

merged 1 commit into from
Apr 6, 2019

Conversation

Kindrat
Copy link
Contributor

@Kindrat Kindrat commented Apr 5, 2019

  • Reformatted code in pdf-html
  • Added more @nullable @nonnull checks
  • Syntax sugar for ChainedProperties to get properties

@Kindrat
More null-check annotations, minot code cleanup, code reformat in htm…
cb5708e 
…l module, added null-safe methods to properties
@andreasrosdal andreasrosdal merged commit d82bfb9 into LibrePDF:master Apr 6, 2019
@andreasrosdal
Copy link
Contributor

andreasrosdal commented Apr 6, 2019 •
edited
Loading

Thanks for submitting this improvement to OpenPDF.

I don't have capacity to review any more such large pull-requests.
I must therefore inform you to please submit only small pull-requests
which solves specific bugs, from now on.

In my opinion, OpenPDF just needs regular bugfixes, not a total refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kindrat @andreasrosdal