Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for CVE-2017-9096 iText XML External Entity Vulnerability #56

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix for CVE-2017-9096 iText XML External Entity Vulnerability #56

merged 1 commit into from
Nov 16, 2017

Conversation

albfernandez
Copy link
Contributor

No description provided.

@tlxtellef tlxtellef self-requested a review November 16, 2017 11:21
tlxtellef
tlxtellef previously requested changes Nov 16, 2017
View reviewed changes
Copy link
Member

@tlxtellef tlxtellef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EntityResolver implementation should be its own class as it is currently defined trice with the same content.

@ghost
Copy link

ghost commented Nov 16, 2017

http://seclists.org/bugtraq/2017/Nov/20

@asturio asturio self-requested a review November 16, 2017 14:41
@tlxtellef tlxtellef dismissed their stale review November 16, 2017 14:44

We can do the minor cleanup after merging.

@tlxtellef tlxtellef merged commit 672c137 into LibrePDF:master Nov 16, 2017
@tlxtellef tlxtellef added the bug label Nov 16, 2017
@tlxtellef tlxtellef added this to the 1.0.5 milestone Nov 16, 2017
@ghost ghost mentioned this pull request Jan 8, 2018
Closed
@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlxtellef tlxtellef tlxtellef left review comments

@asturio asturio Awaiting requested review from asturio

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@albfernandez @tlxtellef