Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications made by TIBCO Software for JasperReports >= 6.2 #58

Merged
merged 3 commits into from
Dec 5, 2017

Conversation

albfernandez
Copy link
Contributor

@albfernandez albfernandez commented Nov 20, 2017

  1. Fix for transparency issue with setClip method in PdfGraphics2D
  2. Fix for transparency bleeding for Batik gradients
  3. Fix for stroke opacity state in the create() method of
    PdfGraphics2D
  4. Method to directly write AWT GlyphVectors to PDF for Indic scripts
    support
  5. No character spacing in justified lines with a single word

Origin:

https://sources.debian.net/patches/libitext-java/2.1.7-11/04_tibco-changes.patch/

http://jaspersoft.artifactoryonline.com/jaspersoft/third-party-ce-artifacts/com/lowagie/itext/2.1.7.js5/itext-2.1.7.js5-sources.jar

 # 1 Fix for transparency issue with setClip method in PdfGraphics2D
 # 2 Fix for transparency bleeding for Batik gradients
 # 3 Fix for stroke opacity state in the create() method of
PdfGraphics2D
 # 4 Method to directly write AWT GlyphVectors to PDF for Indic scripts
support
 # 5 No character spacing in justified lines with a single word
Origin: 

https://sources.debian.net/patches/libitext-java/2.1.7-11/04_tibco-changes.patch/

http://jaspersoft.artifactoryonline.com/jaspersoft/third-party-ce-artifacts/com/lowagie/itext/2.1.7.js5/itext-2.1.7.js5-sources.jar
@@ -49,6 +49,7 @@

package com.lowagie.text.pdf;

import java.awt.font.GlyphVector;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how long are the awt classes being support by the JDK. Just a non relevant comment.

@asturio
Copy link
Member

asturio commented Nov 28, 2017

Ok, this seems fine. And if it is coming from Debian, should be also safe. What I miss by the PRs here is some Test-Code, which is nice to illustrate how things work. Is this too much to expect? Am I too quality-driven? @LibrePDF/openpdf: Any options on that?

I'll probably be merging this in the weekend.

Copy link
Member

@asturio asturio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just wait till the weekend, for someone else look at this. Then I'll merge it.

@@ -71,6 +75,10 @@
*/
boolean vertical = false;

// TIBCO Software #4 : Part 1 - START
Map inverseCmap;
Copy link
Member

@tlxtellef tlxtellef Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add generics if possible.

@@ -3043,7 +3060,18 @@ else if (obj.isArray()) {
}
pdf.incMarkPoint();
mcDepth++;
content.append(struc.get(PdfName.S).getBytes()).append(" <</MCID ").append(mark).append(">> BDC").append_i(separator);
// TIBCO Software #4 : Part 1 - START
//content.append(struc.get(PdfName.S).getBytes()).append(" <</MCID ").append(mark).append(">> BDC").append_i(separator);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No point in keeping commented out code if it is replaced with better code, unless it is to explain better what is going on in the new code.

@@ -1435,7 +1437,15 @@ public void showText(String text) {
showText2(text);
content.append("Tj").append_i(separator);
}


// TIBCO Software #4 : Part 1 - START
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any point in keeping comments like these when we are adopting their changes into the OpenPDF codebase?🤔

@albfernandez
Copy link
Contributor Author

Hi, I've commited your proposed improvements.

Copy link
Member

@asturio asturio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner now! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants