make use of compositeFontDrawer configurable #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Made the use of the 2019s introduced
CompositeFontDrawerconfigurable via system property or by setting it programmatically via setter. Staying backwards compatible by enabling the compositeFontDrawer by default.Related Issue: #587
Compatibilities Issues
Backwards compatible
Testing details
Generate PDF with custom mapper that does not default to Helvetica and use different fonts from Sans-Serif. Try using Helvetica without having it installed (e.g. Windows or *nix) and it will simply choose another Sans-Serif font(s) that is able to display the specified character(s).
With the new flag enabled the old behaviour is used which works perfectly fine for us since the given fonts in
PdfGraphics2Dwere correctly initialized in our code. If in any case on the target system the specified font cannot be found an exception should be thrown rather than using another font (which was done with the old behaviour).