Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug about SAXiTextHandler #714

Merged
merged 3 commits into from
May 11, 2022
Merged

Fix bug about SAXiTextHandler #714

merged 3 commits into from
May 11, 2022

Conversation

chappyer
Copy link

@chappyer chappyer commented Apr 22, 2022

Description of the Bugfix

This pull request mainly solves two problems

  • Problem1
    When converting a html file to a pdf file, the layout of the generated file should be the same as the layout of the html file, so the content between title tag in html file should not write in pdf file.
  • Problem2
    There are some unnecessary spaces in the generated pdf file, which causes the layout of the generated pdf file wrong.

Related Issue: #706

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug

Compatibilities Issues

There are no compatibility problems with the new code so far

Testing details

  • Two scenario test to reproduce scenario of the bug
  • Two junit smoke test to test whether PDF documents can be generated correctly

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chappyer chappyer marked this pull request as ready for review April 24, 2022 15:00
@asturio asturio linked an issue May 11, 2022 that may be closed by this pull request
@asturio asturio merged commit 5006f28 into LibrePDF:master May 11, 2022
@asturio asturio added this to the 1.3.28 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HtmlParser: maybe there should be a new line between title and body
2 participants