Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #718 #719

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix #718 #719

merged 1 commit into from
May 11, 2022

Conversation

liefke
Copy link

@liefke liefke commented Apr 25, 2022

Description of the Bugfix

Prevent ArrayIndexOutOfBoundsException and use the same boundary checks for arrays and dictionaries.

Related Issue: #718

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug
  • Unit-Tests added to the added feature

Compatibilities Issues

This shouldn't change the compatibility for valid PDF files.

Testing details

Nothing specific.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@mluppi mluppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me and makes sense. Thanks for your contribution.

@andreasrosdal
Copy link
Contributor

Thank you for making this pull request. I hope that this will be accepted and included in a new release. Thank you!

@asturio asturio merged commit 23b042a into LibrePDF:master May 11, 2022
@asturio asturio added this to the 1.3.28 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException when opening PDF file with invalid indirect reference
4 participants