Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height calculation for table rows with rowspan #865

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

fellmann
Copy link
Contributor

@fellmann fellmann commented Jan 10, 2023

Description of the new Feature/Bugfix

Fixes #864

  • Fix calculation of row heights when using rowspan
  • Row heights for tables that contain cells with rowspan > 1 are calculated on first access to row heights.
  • Additional space necessary to fit the contents of the rowspanning cell is distributed as evenly as possible among all rows.

Bug was introduced with #693

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug
  • Unit-Tests added to the added feature

Compatibilities Issues

No changes should be visible to the user.

Testing details

Any other details about how to test the new feature or bugfix?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fellmann
Copy link
Contributor Author

@asturio Any idea when this can be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using rowspan leads to overlapping table rows
2 participants