Add flag to inhibit FOP glyph substitution #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
openpdf/src/main/java/com/lowagie/text/TextRenderingOptions.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/LibrePDF/OpenPDF/904.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/LibrePDF/OpenPDF/904.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
|
Kudos, SonarCloud Quality Gate passed!
|
asturio
reviewed
Aug 16, 2023
openpdf/src/main/java/com/lowagie/text/TextRenderingOptions.java
Outdated
Show resolved
Hide resolved
openpdf/src/main/java/com/lowagie/text/TextRenderingOptions.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
When FOP is present on the classpath, it will be automatically used to perform glyph substitutions, which are mandatory for complex layout scripts.
But for scripts where glyph substitutions are optional (e.g. Latin ligatures), it makes sense to have an enable/disable flag because glyph substitutions come with drawbacks such as incorrect text when copying from the document.
The PR introduces a new method
Document.setGlyphSubstitutionEnabledthat can be used to disable glyph substitutions when FOP is present.Related Issue: #297