Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#954 Speed up loading fonts from JAR #955

Merged

Conversation

asolntsev
Copy link
Contributor

Description of the new Feature/Bugfix

I've wrapped InputStream into BufferedInputStream. That made much faster loading fonts from openpdf-*.jar.

Related Issue: #954

Unit-Tests for the new Feature/Bugfix

  • Unit-Tests added to reproduce the bug
  • Unit-Tests added to the added feature

The test is described in #954.
Running test inside of OpenPDF doesn't really show the problem, so I decided not to commit it.

Compatibilities Issues

No.

Testing details

Described in #954

wrapping InputStream to BufferedInputStream makes much faster loading fonts from openpdf-*.jar
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asolntsev
Copy link
Contributor Author

asolntsev commented Sep 25, 2023

@asturio @andreasrosdal @JAndrassy ^^^ friendly reminder ^^^

@asolntsev
Copy link
Contributor Author

@dadza @andreasrosdal @asturio Is there anybody?... :(

@andreasrosdal andreasrosdal merged commit beb73f8 into LibrePDF:master Nov 1, 2023
4 checks passed
@asolntsev asolntsev deleted the fix/954-speed-up-loading-fonts branch November 1, 2023 10:32
@andreasrosdal andreasrosdal added this to the 1.3.32 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants