enable green and blue lasers #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add UI for laser color choice (default red), get the correct color channel matching that choice, default profile info
|
what is still to do to implement this? |
|
It is done, the changes just need to be integrated into the mainline.
Chris
…On 9/7/17, 2:32 PM, "3DSTB" ***@***.***> wrote:
what is still to do to implement this?
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/bqlabs/horus/pull/108#issuecomment-327933112> , or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZ_V4HZgNA1tNqwhUZsfJIIdVTx
PmfYOks5sgGDigaJpZM4M6yHu> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb"
,"name":"GitHub"},"entity":{"external_key":"github/bqlabs/horus","title":"bqla
bs/horus","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/14341
8/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https
://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-
b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/bqlabs/horus"}},"updates":{"snippets":[{"ico
***@***.*** in #108: what is still to do to implement
this?"}],"action":{"name":"View Pull
Request","url":"https://github.com/bqlabs/horus/pull/108#issuecomment-32793311
2"}}}
|
|
Hi Chris, Steffen |
|
Yeah, I get the feeling that the owner has abandoned it and not named a
replacement maintainer.
Chris
…On 9/7/17, 11:06 PM, "3DSTB" ***@***.***> wrote:
Hi Chris,
your request is from april. Who is responsible for the integration. It looks
as if nobody is there anymore.
Steffen
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/bqlabs/horus/pull/108#issuecomment-328007675> , or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZ_V4Fa3j4uzNChngGOPWdMWjoj
rPGUJks5sgNlcgaJpZM4M6yHu> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb"
,"name":"GitHub"},"entity":{"external_key":"github/bqlabs/horus","title":"bqla
bs/horus","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/14341
8/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https
://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-
b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/bqlabs/horus"}},"updates":{"snippets":[{"ico
***@***.*** in #108: Hi Chris,\r\nyour request is from
april. Who is responsible for the integration. It looks as if nobody is there
anymore.\r\n\r\nSteffen"}],"action":{"name":"View Pull
Request","url":"https://github.com/bqlabs/horus/pull/108#issuecomment-32800767
5"}}}
|
|
Is there a way to compile the windows version without integration? I really want to use some green lasers. |
|
So i replaced your files in the installation directory with your files and then delete the .pyc files. Is that all? Where can i change the laser color and brightness in the programm? |
|
The settings will be in the adjustment workbench, right? I have no scanner here to test. |
|
So i just used the UNO and the Camera and i can the the settings. |
|
Yes, just change the laser color in the adjustment workbench.
…On 9/8/17, 5:58 AM, "3DSTB" ***@***.***> wrote:
The settings will be in the adjustment workbench, right? I have no scanner
here to test.
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/bqlabs/horus/pull/108#issuecomment-328096367> , or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZ_V4JJnuF3oE0fu-7AL1zp5NJj
PWePVks5sgToMgaJpZM4M6yHu> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb"
,"name":"GitHub"},"entity":{"external_key":"github/bqlabs/horus","title":"bqla
bs/horus","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/14341
8/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https
://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-
b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/bqlabs/horus"}},"updates":{"snippets":[{"ico
***@***.*** in #108: The settings will be in the adjustment
workbench, right? I have no scanner here to test."}],"action":{"name":"View
Pull
Request","url":"https://github.com/bqlabs/horus/pull/108#issuecomment-32809636
7"}}}
|
|
Hi ChrisCoxArt, |
|
I wrote the code for the main depot version of the app. It won¹t work with
older versions.
Chris
…On 10/19/17, 12:06 PM, "3DSTB" ***@***.***> wrote:
Hi ChrisCoxArt,
the code works fine for me.
I have seen now that there are some improements in the release0.2-tree. When i
include this, the green laser mode doas not work: b8aad94
<b8aad94
ae87cea4>
Have you an idea why?
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#108 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AZ_V4BSUZTcW2XOm_UEnWYgK-We
R969xks5st53FgaJpZM4M6yHu> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb"
,"name":"GitHub"},"entity":{"external_key":"github/LibreScanner/horus","title"
:"LibreScanner/horus","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/14341
8/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https
://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-
b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/LibreScanner/horus"}},"updates":{"snippets":
***@***.*** in #108: Hi ChrisCoxArt,\r\nthe code works
fine for me.\r\nI have seen now that there are some improements in the
release0.2-tree. When i include this, the green laser mode doas not work:
b8aad94
e87cea4\r\nHave you an idea why?"}],"action":{"name":"View Pull
Request","url":"#108 (comment)
8006732"}}}
|
|
The release/02-tree is the latest code from the developer of horus (Jesus89) and is a fork of the develop-tree after the 2. June 2016. It should be compatible with your code in general. Unfortunitely i can not figure out the problem. |
jerry8092
approved these changes
Aug 3, 2018
I've added the same color detection scheme to my fork. But using HSV range to detect laser line seems more flexible than just pull channels from image. At the moment i've added HSV detector hardcoded for red color. Adding GUI controls for HSV method is thing TODO. But you can easily adjust HSV detector for your custom laser color at src/horus/engine/algorithms/laser_segmentation.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add UI for laser color choice (default red), get the correct color
channel matching that choice, default profile info