-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic turning, based on location #5
Comments
Good idea, this would be very convenient for the users. I'll add it to the planned feature list and will probably look into it sometime in the future. However, if anyone else likes to implement it, pull requests are welcome. |
It would be even greater if the app could dim the screen gradually based on location, like redshift does. |
Do you mean that the filter should change gradually when transitioning from day to night? |
Yes, that way the eyes can slowly adapt.
It would be great if red moon behaves in a similar way. |
Yeah, that's a good idea. I will keep that in mind. |
I would favour the gradually dimming as proposed by @tastytea. |
I agree, gradually dimming would be better.
That library looks great, nice find. |
See #5 See #17 The user now has the option to automatically turn the filter on and off. If they select the option, they can choose at what times the filter is turned on and off. Later the user may have the choice to not select the turn on and off times manually, but to automatically turn on and of at sunrise and sunset.
like twilight app, it would be great |
Many users turn off automatic location service for security/privacy reasons. It would be nice if there were an option to select the location manually. |
I agree, however I'm not sure of an effective way to prompt the user for their location. Would letting them simply enter their coordinates suffice? |
Letting users enter their coordinates does it, but I think there should be a library to automatically translate city names to coordinates somewhere. I'm really not familiar to android development, but I'm sure there are such libraries in many other languages. When users try to enter their city name, it would search the city name in database and suggests possible results while typing, and user selects the right city. |
You can let user choose between location or date and time based guess (less precise but privacy friendly) |
To get coordinates for a city / region / address you could use:
|
I don't think this will be precise enough to make a meaningful guess, since the timezone only tells me anything about the longitude, which doesn't correlate with the local sunrise and sunset times.
Thanks for the link, that would be a possibility. However I'm cautious on introducing more permissions, like internet access, to Red Moon unless it is absolutely necessary. |
OsmAnd does this by downloading some wikipedia data. They do it in their own download manager, which requires internet permission, but this app could just include a link to where you can download that information, then import the data from a file. |
another workaround to prevent Internet access is to let users select their location by touch on a world map image, which returns the coordinats. On ۴ آوریل ۲۰۱۶ ۹:۲۲:۳۲ (GMT+04:30), smichel17 notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
Yes, I agree that may be a good solution, since the location doesn't need to be very precise at all. |
This is how Twilight does it. For me, it's actually annoying -- I always wish I could just select more precisely with the tap. However, it would be a great interface if there were a way to zoom in a little bit. |
Okay, here's a maybe controversial question: is it important that to be able to manually set your location? Principle: The main advantage of automatically setting the timer based on location is that it requires almost no thought/effort put into configuration. Therefore, if it takes more effort to manually set your location than it would to manually set the timer, there is no point of the feature and we should not offer it. It doesn't take that much effort to manually set the timer. I know when I wake up each day, and I know approximately what time the sun goes down. Certainly less effort than downloading a bunch of location data from wikipedia. Probably less effort than manually entering your location (who knows their lattitude and longitude off hand?). Depending on the interface, it might even be easier than setting your location on a map -- Twilight's map was imprecise enough that I had to try several times before I got an accurate enough location. By that reasoning, we shouldn't offer the ability to manually set your location, even if it was trivial to develop (I'm not really sure how hard it would be). There is one thing left out from the argument above: It also takes effort to keep the timer in sync with the sun as the days get shorter and longer*. Is there a way to get this without inputting your location? I'm not sure. There might be. Is it possible to get a location based on the time of year and the sunrise/sunset times? If so, we could allow setting the default location based on the user-set times, and then Red Moon can update the timer based on that location. If that works, it seems like the easiest way, both from a user's point of view and effort to develop.
|
This was originally a larger issue, which makes reading through it fairly unfocused. So, I'm closing it and created #206 to track the remaining part (manual location). |
It would be great if the app could turn itself on in a duration after sunset of the users location and turn off in a duration before sunrise.
The text was updated successfully, but these errors were encountered: