Start using CodeIgniter DB migrations #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've already done a few schema changes "out of band", but with LibriVox#212 we now have a situation where a schema change is needed in a PR for the code to work, and since we have no way to supply that, our CI (continuout integration, not Code Ingiter), basic such as it is, fails because the schema that the code relies on is not deployed in the CI VM. In addition, tracking schema changes inline with migrations is just good standard practice. This patch starts making use of Code Igniter's DB migrations framework (https://codeigniter.com/userguide3/libraries/migration.html) to allow PRs to include schema changes. There will be a librivox-ansible follow-up patch to run the DB migrate script on every deployment.
notartom
added a commit
to notartom/librivox-ansible
that referenced
this pull request
Apr 1, 2024
Following up on LibriVox/librivox-catalog#213, run the DB migrate command to enable CI to pass when DB schema changes are needed.
notartom
added a commit
to notartom/librivox-ansible
that referenced
this pull request
Apr 1, 2024
Following up on LibriVox/librivox-catalog#213, run the DB migrate command to enable CI to pass when DB schema changes are needed.
notartom
added a commit
to LibriVox/librivox-ansible
that referenced
this pull request
Apr 1, 2024
Following up on LibriVox/librivox-catalog#213, run the DB migrate command to enable CI to pass when DB schema changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already done a few schema changes "out of band", but with
#212 we now have a
situation where a schema change is needed in a PR for the code to
work, and since we have no way to supply that, our CI (continuous
integration, not Code Igniter), basic such as it is, fails because the
schema that the code relies on is not deployed in the CI VM.
In addition, tracking schema changes inline with migrations is just
good standard practice.
This patch starts making use of Code Igniter's DB migrations framework
(https://codeigniter.com/userguide3/libraries/migration.html) to allow
PRs to include schema changes. There will be a librivox-ansible
follow-up patch to run the DB migrate script on every deployment.