more filters when requesting game metas #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicwest
reviewed
Dec 1, 2024
heltour/tournament/lichessapi.py
Outdated
| def get_latest_game_metas(lichess_username, number, priority=0, max_retries=5, timeout=1800): | ||
| url = '%s/lichessapi/api/games/user/%s?max=%s&ongoing=true&priority=%s&max_retries=%s&format=application/x-ndjson' % ( | ||
| settings.API_WORKER_HOST, lichess_username, number, priority, max_retries) | ||
| def get_latest_game_metas(lichess_username, since, number, opponent, priority=0, max_retries=5, timeout=1800): |
There was a problem hiding this comment.
Suggested change
| def get_latest_game_metas(lichess_username, since, number, opponent, priority=0, max_retries=5, timeout=1800): | |
| def get_latest_game_metas(*, lichess_username, since, number, opponent, priority=0, max_retries=5, timeout=1800): |
positional arguments are the devil, use * to enforce keyword arguments and make your code more readable/less error prone!
heltour/tournament/lichessapi.py
Outdated
| settings.API_WORKER_HOST, lichess_username, number, priority, max_retries) | ||
| def get_latest_game_metas(lichess_username, since, number, opponent, priority=0, max_retries=5, timeout=1800): | ||
| url = '%s/lichessapi/api/games/user/%s?since=%s&max=%s&vs=%s&ongoing=true&priority=%s&max_retries=%s&format=application/x-ndjson' % ( | ||
| settings.API_WORKER_HOST, lichess_username, since, number, opponent, priority, max_retries) |
There was a problem hiding this comment.
use .format() or preferable a format string f"{settings.API_WORKER_HOST}/lichessapi..."
There was a problem hiding this comment.
glbert-does
force-pushed
the
498_gamefilter
branch
from
f7c8e7f to
f838b52
Compare
|
implemented nic's comments and rebased from branch django_update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #498. hopefully.
for games that are supposed to start soon, we requested the last games of the white player from lichess. we now filter these to only request games since the round started + only against the black player.
while i am still not certain how the bug above worked exactly, i assume that this should fix it. otherwise, i am out of ideas.
edit: rebased on #527
more edits: i believe this closes #255 as well.
edit to the edits: closes #202 too.